On Thu, Jun 16, 2022 at 01:25:25AM +0530, Kirti Wankhede wrote:
>> + parent->mdev_types_kset = kset_create_and_add("mdev_supported_types",
>> + NULL, &parent->dev->kobj);
>> + if (!parent->mdev_types_kset)
>> + return -ENOMEM;
>> +
>> + for (i = 0; i < nr_types; i++) {
>> + ret = mdev_type_add(parent, types[i]);
>> + if (ret)
>> + break;
>> + }
>
> Above code should be in parent_create_sysfs_files(), all sysfs related
> stuff should be placed in mdev_sysfs.c
Yes, it could. But why? This is core logic of the interface and has
nothing to do with sysfs.
