> From: Eric Farman <farman@xxxxxxxxxxxxx> > Sent: Tuesday, June 7, 2022 4:24 AM > > On Tue, 2022-06-07 at 01:32 +0530, Kirti Wankhede wrote: > > > > On 6/2/2022 10:49 PM, Eric Farman wrote: > > > From: Jason Gunthorpe <jgg@xxxxxxxxxx> > > > @@ -106,6 +106,7 @@ structure to represent a mediated device's > > > driver:: > > > int (*probe) (struct mdev_device *dev); > > > void (*remove) (struct mdev_device *dev); > > > struct device_driver driver; > > > + unsigned int (*get_available)(struct mdev_type *mtype); > > > }; > > > > > > > This patch conflicts with Christoph Hellwig's patch. I see > > 'supported_type_groups' is not is above structure, I beleive that > > your > > patch is applied on top of Christoph's patch series. > > > > but then in below part of code, 'add_mdev_supported_type' has also > > being > > removed in Christoph's patch. So this patch would not get applied > > cleanly. > > Apologies. This series was fit to 5.18 as the merge window progressed. > Both this patch and the previous one have to adjust to the removal of > mdev_parent_ops that came about from > > commit 6b42f491e17ce13f5ff7f2d1f49c73a0f4c47b20 > Author: Jason Gunthorpe <jgg@xxxxxxxx> > Date: Mon Apr 11 16:14:01 2022 +0200 > > vfio/mdev: Remove mdev_parent_ops > > I have this rebased for v2. > btw with those latest changes [1] we don't need .get_available() then, as mdev type is now added by mdev driver one-by-one then the available instance can be provided directly in that path. [1] https://lore.kernel.org/all/20220607055653.GA8848@xxxxxx/T/#m82caa423d728bce0729b8c9e8d8aff76250ec9ac