On 6/5/22 11:37, Stafford Horne wrote: > On Fri, Jun 03, 2022 at 03:44:11PM +0530, Anshuman Khandual wrote: >> This defines and exports a platform specific custom vm_get_page_prot() via >> subscribing ARCH_HAS_VM_GET_PAGE_PROT. Subsequently all __SXXX and __PXXX >> macros can be dropped which are no longer needed. >> >> Cc: Jonas Bonn <jonas@xxxxxxxxxxxx> >> Cc: openrisc@xxxxxxxxxxxxxxxxxxxx >> Cc: linux-kernel@xxxxxxxxxxxxxxx >> Acked-by: Stafford Horne <shorne@xxxxxxxxx> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx> > > Is it possible to retract my Acked-by? I was following the discussion of this > new function actually being sub optimal. So as far as I am concerned all these > architecture patches should be nak'ed. Sure, alright. I am planning to redo these arch patches via making the protection_map[] array private to the platforms but possibly with a common look up function as Christophe had suggested earlier.
