On Fri, May 27 2022, Jason Wang <jasowang@xxxxxxxxxx> wrote: > This patch allows the new introduced __virtio_break_device() to > unbreak the virtqueue. > > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxx> > Cc: Marc Zyngier <maz@xxxxxxxxxx> > Cc: Halil Pasic <pasic@xxxxxxxxxxxxx> > Cc: Cornelia Huck <cohuck@xxxxxxxxxx> > Cc: Vineeth Vijayan <vneethv@xxxxxxxxxxxxx> > Cc: Peter Oberparleiter <oberpar@xxxxxxxxxxxxx> > Cc: linux-s390@xxxxxxxxxxxxxxx > Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx> > --- > drivers/virtio/virtio_ring.c | 22 ++++++++++++++++++++++ > include/linux/virtio.h | 1 + > 2 files changed, 23 insertions(+) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 9d0bae4293be..9c231e1fded7 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -2395,6 +2395,28 @@ void virtio_break_device(struct virtio_device *dev) > } > EXPORT_SYMBOL_GPL(virtio_break_device); > > +/* > + * This should allow the device to be used by the driver. You may > + * need to grab appropriate locks to flush the write to > + * vq->broken. This should only be used in some specific case e.g > + * (probing and restoring). This function should only be called by the Minor: "...some specific cases, e.g. probing and restoring." But no need to respin from my side. > + * core, not directly by the driver. > + */ Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>
