On Fri, 20 May 2022 10:15:38 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote: > On Fri, 2022-05-20 at 13:57 +0200, Juerg Haefliger wrote: > > The convention for indentation seems to be a single tab. Help text is > > further indented by an additional two whitespaces. Fix the lines that > > violate these rules. > > > > While add it, add trailing comments to endmenu statements for better > > readability. > [] > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > [] > > @@ -607,7 +607,7 @@ config RANDOMIZE_BASE > > as a security feature that deters exploit attempts relying on > > knowledge of the location of kernel internals. > > > > -endmenu > > +endmenu # "Processor type and features" > > An endmenu comment is relatively unusual. > > $ git grep '^endmenu' -- '*/Kconfig*' | wc -l > 394 > $ git grep '^endmenu.*#' -- '*/Kconfig*' | wc -l > 20 > > I believe it doesn't really help readability. Thanks for the review. Will send a v2 without that. ...Juerg >
Attachment:
pgpVGzs0m1654.pgp
Description: OpenPGP digital signature
