On Fri, 13 May 2022 10:13:14 +0800 Li kunyu <kunyu@xxxxxxxxxxxx> wrote: > Subject: [PATCH] kernel: Ftrace seems to have functions to improve performance through optimization through optimization Did you forget to add a subject line. The above looks to be the beginning of the paragraph below. > Date: Fri, 13 May 2022 10:13:14 +0800 > Message-Id: <20220513021314.59480-1-kunyu@xxxxxxxxxxxx> > > such as ftrace_ARCH_code_*, return 0, so the FTRACE_* check is not required And even combined, the above makes no sense. This patch is not an optimization patch. If it were, the optimization provided is so small, it's not worth adding it. Just state that it's a clean up (I already told you this). Here, I'll do the work for you (but I expect a proper patch): Subject: [PATCH v2] ftrace: Remove return value of ftrace_arch_modify_*() All instances of the function ftrace_arch_modify_prepare() and ftrace_arch_modify_post_process() return zero. There's no point in checking their return value. Just have them be void functions. There, that's what I would like to see. -- Steve > > Signed-off-by: Li kunyu <kunyu@xxxxxxxxxxxx>
