Re: [PATCH v9 2/3] s390x: KVM: guest support for topology function

To: Pierre Morel <pmorel@xxxxxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v9 2/3] s390x: KVM: guest support for topology function
From: Janosch Frank <frankja@xxxxxxxxxxxxx>
Date: Thu, 12 May 2022 13:41:56 +0200
Cc: linux-s390@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, borntraeger@xxxxxxxxxx, cohuck@xxxxxxxxxx, david@xxxxxxxxxx, thuth@xxxxxxxxxx, imbrenda@xxxxxxxxxxxxx, hca@xxxxxxxxxxxxx, gor@xxxxxxxxxxxxx, wintera@xxxxxxxxxxxxx, seiden@xxxxxxxxxxxxx, nrb@xxxxxxxxxxxxx
In-reply-to: <20220506092403.47406-3-pmorel@linux.ibm.com>
References: <20220506092403.47406-1-pmorel@linux.ibm.com> <20220506092403.47406-3-pmorel@linux.ibm.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0

On 5/6/22 11:24, Pierre Morel wrote:

We let the userland hypervisor know if the machine support the CPU
topology facility using a new KVM capability: KVM_CAP_S390_CPU_TOPOLOGY.


Nope, we indicate KVM's support which is based on the machine's support.

On the same note: Shouldn't the CAP indication be part of the lastpatch? The resets are needed for a full support of this feature, no?

Follow-Ups:
- Re: [PATCH v9 2/3] s390x: KVM: guest support for topology function
  - From: Pierre Morel

References:
- [PATCH v9 0/3] s390x: KVM: CPU Topology
  - From: Pierre Morel
- [PATCH v9 2/3] s390x: KVM: guest support for topology function
  - From: Pierre Morel