On Wed, May 11, 2022 at 12:27 PM Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote: > > On Wed, May 11, 2022 at 5:05 AM Heiko Carstens <hca@xxxxxxxxxxxxx> wrote: > > > > Before version 14.0.0 llvm's integrated assembler fails to handle some > > displacement variants: > > > > arch/s390/purgatory/head.S:108:10: error: invalid operand for instruction > > lg %r11,kernel_type-.base_crash(%r13) > > > > Instead of working around this and given that this is already fixed > > raise the minimum clang version from 13.0.0 to 14.0.0. > > Do you have the commit in LLVM that fixed this? Might be nice to link Maybe it's https://reviews.llvm.org/D113341? Also, these are the open issues we had for the integrated assembler. https://github.com/ClangBuiltLinux/linux/issues?q=is%3Aopen+is%3Aissue+label%3A%22%5BARCH%5D+s390%22+label%3A%22%5BTOOL%5D+integrated-as%22 Any chance you could include relevant Link tags on your commit messages for patches that address these? It makes it easier to track when/where things land if we ever intend to backport anything to stable. Or can any of those be closed out? > to the particular commit in the commit message. Either way: > Acked-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > (Thanks for the series, will pull down and test!) > > If you have a github account, let me know it if you'd like to be cc'ed > when we wire this up in our CI. > > > > > Signed-off-by: Heiko Carstens <hca@xxxxxxxxxxxxx> > > --- > > scripts/min-tool-version.sh | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh > > index 53fe64856015..f1e8358ec19a 100755 > > --- a/scripts/min-tool-version.sh > > +++ b/scripts/min-tool-version.sh > > @@ -24,9 +24,8 @@ icc) > > echo 16.0.3 > > ;; > > llvm) > > - # https://lore.kernel.org/r/YMtib5hKVyNknZt3@osiris/ > > if [ "$SRCARCH" = s390 ]; then > > - echo 13.0.0 > > + echo 14.0.0 > > else > > echo 11.0.0 > > fi > > -- > > 2.32.0 > > > > > -- > Thanks, > ~Nick Desaulniers -- Thanks, ~Nick Desaulniers
