Hi, Harald, Thank you for your response, review and an ACK. Let me ask Herbert if he would agree to add your Reviewed-by and submit (so I do not send v2 just for this). Best regards, Vladis On Mon, May 9, 2022 at 12:10 PM Harald Freudenberger <freude@xxxxxxxxxxxxx> wrote: > > On 2022-05-08 15:09, Vladis Dronov wrote: > > From: Vladis Dronov <vdronov@xxxxxxxxxx> > > > > Implement a crypto library interface for the s390-native ChaCha20 > > cipher > > algorithm. This allows us to stop to select CRYPTO_CHACHA20 and instead > > select CRYPTO_ARCH_HAVE_LIB_CHACHA. This allows BIG_KEYS=y not to build > > a whole ChaCha20 crypto infrastructure as a built-in, but build a > > smaller > > CRYPTO_LIB_CHACHA instead. > > > > Make CRYPTO_CHACHA_S390 config entry to look like similar ones on other > > architectures. Remove CRYPTO_ALGAPI select as anyway it is selected by > > CRYPTO_SKCIPHER. > > > > Add a new test module and a test script for ChaCha20 cipher and its > > interfaces. Here are test results on an idle z15 machine: > > > > ...skip... > > Hello Vladis > Thanks for your work. Please add my > Reviewed-by: Harald Freudenberger <freude@xxxxxxxxxxxxx> > > however, always the question who will pick and forward this patch ? > To me this looks like most parts are common so I would suggest that > Herbert Xu will pick this patch. >