On 4/27/2022 3:49 PM, Guilherme G. Piccoli wrote:
The panic notifier of this driver is very simple code-wise, just a memory write to a special position with some numeric code. But this is not clear from the semantic point-of-view, and there is no public documentation about that either. After discussing this in the mailing-lists [0] and having Florian explained it very well, this patch just document that in the code for the future generations asking the same questions. Also, it removes a useless header. [0] https://lore.kernel.org/lkml/781cafb0-8d06-8b56-907a-5175c2da196a@xxxxxxxxx Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)") Cc: Brian Norris <computersforpeace@xxxxxxxxx> Cc: Doug Berger <opendmb@xxxxxxxxx> Cc: Florian Fainelli <f.fainelli@xxxxxxxxx> Cc: Justin Chen <justinpopo6@xxxxxxxxx> Cc: Lee Jones <lee.jones@xxxxxxxxxx> Cc: Markus Mayer <mmayer@xxxxxxxxxxxx> Signed-off-by: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx>
Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx> Likewise, I am not sure if the Fixes tag is necessary here. -- Florian
