On Tue, Apr 26, 2022 at 07:31:14PM +0200, Borislav Petkov wrote: > On Tue, Apr 26, 2022 at 03:40:20PM +0200, Juergen Gross wrote: > > diff --git a/kernel/platform-feature.c b/kernel/platform-feature.c > > new file mode 100644 > > index 000000000000..2d52f8442cd5 > > --- /dev/null > > +++ b/kernel/platform-feature.c > > @@ -0,0 +1,7 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#include <linux/cache.h> > > +#include <linux/platform-feature.h> > > + > > +unsigned long __read_mostly platform_features[PLATFORM_FEAT_ARRAY_SZ]; > > Probably __ro_after_init. > > > +EXPORT_SYMBOL_GPL(platform_features); > > You probably should make that thing static and use only accessors to > modify it in case you wanna change the underlying data structure in the > future. That would add another indirection, which at least I think is not necessary, and would make it less likely that this infrastructure is used.