Re: [PATCH v8 1/2] s390x: KVM: guest support for topology function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 20 Apr 2022 14:05:00 +0200
Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:

> > +static inline bool kvm_s390_topology_changed(struct kvm_vcpu *vcpu)
> > +{
> > +	if (!test_kvm_facility(vcpu->kvm, 11))
> > +		return false;
> > +
> > +	/* A new vCPU has been hotplugged */
> > +	if (vcpu->arch.prev_cpu == S390_KVM_TOPOLOGY_NEW_CPU)
> > +		return true;
> > +
> > +	/* The real CPU backing up the vCPU moved to another socket */
> > +	if (cpumask_test_cpu(vcpu->cpu,
> > +			     topology_core_cpumask(vcpu->arch.prev_cpu)))
> > +		return true;
> > +
> > +	return false;
> > +}  
> 
> This seems to be wrong. I'd guess that you need
> 
> 	if (cpumask_test_cpu(vcpu->cpu,
> 			     topology_core_cpumask(vcpu->arch.prev_cpu)))
> -->		return false;
> -->	return true;  

so if the CPU moved to a different socket, it's not a change?
and if nothing happened, it is a change?



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux