Hi,
Haowen Bai <baihaowen@xxxxxxxxx> writes:
> Use kzalloc rather than duplicating its implementation, which
> makes code simple and easy to understand.
>
> Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>
> ---
> drivers/s390/block/dasd_eckd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
> index 8410a25a65c1..74a035c56c3e 100644
> --- a/drivers/s390/block/dasd_eckd.c
> +++ b/drivers/s390/block/dasd_eckd.c
> @@ -1480,7 +1480,7 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
> {
> struct pe_handler_work_data *data;
>
> - data = kmalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
> + data = kzalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
> if (!data) {
> if (mutex_trylock(&dasd_pe_handler_mutex)) {
> data = pe_handler_worker;
> @@ -1489,7 +1489,6 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
> return -ENOMEM;
> }
> } else {
> - memset(data, 0, sizeof(*data));
> data->isglobal = 0;
Maybe also remove the isglobal assigment above, so the whole else block
could go away?
> }
> INIT_WORK(&data->worker, do_pe_handler_work);
Thanks,
Sven
