On Tue, Mar 22, 2022 at 11:00:57AM +0800, Yu Liao wrote: > cleanup the s390's use of the timer API > - del_timer() contains timer_pending() condition > - mod_timer(timer, expires) is equivalent to: > > del_timer(timer); > timer->expires = expires; > add_timer(timer); > > If the timer is inactive it will be activated, using add_timer() on > condition !timer_pending(&private->timer) is redundant. > > Just cleanup, no logic change. > > Signed-off-by: Yu Liao <liaoyu15@xxxxxxxxxx> > --- > drivers/s390/char/sclp.c | 4 +--- > drivers/s390/char/sclp_con.c | 3 +-- > drivers/s390/char/sclp_vt220.c | 6 ++---- > drivers/s390/cio/device_fsm.c | 12 +++--------- > drivers/s390/cio/eadm_sch.c | 12 +++--------- > 5 files changed, 10 insertions(+), 27 deletions(-) Applied, thanks.