Re: [PATCH v18 14/18] s390/vfio-ap: sysfs attribute to display the guest's matrix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/22/22 09:22, Jason J. Herne wrote:
On 2/14/22 19:50, Tony Krowiak wrote:
The matrix of adapters and domains configured in a guest's APCB may
differ from the matrix of adapters and domains assigned to the matrix mdev,
so this patch introduces a sysfs attribute to display the matrix of
adapters and domains that are or will be assigned to the APCB of a guest
that is or will be using the matrix mdev. For a matrix mdev denoted by
$uuid, the guest matrix can be displayed as follows:

    cat /sys/devices/vfio_ap/matrix/$uuid/guest_matrix
My OCD wants you to name this matrix_guest instead of guest_matrix. Simply because then "matrix" and "matrix_guest" will be grouped together when doing an ls on the parent directory. As a system admin, its the little things that make the difference :) Please consider... though I won't withhold an R-b for
it.

I am going to leave it as guest_matrix for two reasons:
1. To me, the name matrix_guest reads like the guest belongs to the matrix rather
    than the matrix belonging to the guest.
2. Changing it will require changes to all of the automated test cases that check     sysfs to determine whether the attribute is present and I don't think the juice
    is worth the squeeze.


Reviewed-by: Jason J. Herne <jjherne@xxxxxxxxxxxxx>





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux