Re: [PATCH net-next v3] net/smc: fix compile warning for smc_sysctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 3/6/22 17:54, Dust Li wrote:
> kernel test robot reports multiple warning for smc_sysctl:

when SYSCTL is not enabled
(AFAIK)

>   In file included from net/smc/smc_sysctl.c:17:
>>> net/smc/smc_sysctl.h:23:5: warning: no previous prototype \
> 	for function 'smc_sysctl_init' [-Wmissing-prototypes]
>   int smc_sysctl_init(void)
>        ^
> and
>   >> WARNING: modpost: vmlinux.o(.text+0x12ced2d): Section mismatch \
>   in reference from the function smc_sysctl_exit() to the variable
>   .init.data:smc_sysctl_ops
>   The function smc_sysctl_exit() references
>   the variable __initdata smc_sysctl_ops.
>   This is often because smc_sysctl_exit lacks a __initdata
>   annotation or the annotation of smc_sysctl_ops is wrong.
> 
> and
>   net/smc/smc_sysctl.c: In function 'smc_sysctl_init_net':
>   net/smc/smc_sysctl.c:47:17: error: 'struct netns_smc' has no member named 'smc_hdr'
>      47 |         net->smc.smc_hdr = register_net_sysctl(net, "net/smc", table);
> 
> Since we don't need global sysctl initialization. To make things
> clean and simple, remove the global pernet_operations and
> smc_sysctl_{init|exit}. Call smc_sysctl_net_{init|exit} directly
> from smc_net_{init|exit}.
> 
> Also initialized sysctl_autocorking_size if CONFIG_SYSCTL it not
> set, this make sure SMC autocorking is enabled by default if
> CONFIG_SYSCTL is not set.
> 
> Fixes: 462791bbfa35 ("net/smc: add sysctl interface for SMC")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Dust Li <dust.li@xxxxxxxxxxxxxxxxx>
> 
> ---
> v3: 1. add __net_{init|exit} annotation for smc_sysctl_net_{init|exit}
>        sugguested by Jakub Kicinski
>     2. Remove static inline for smc_sysctl_net_{init|exit} if
>        CONFIG_SYSCTL not defined
> v2: 1. Removes pernet_operations and smc_sysctl_{init|exit}
>     2. Initialize sysctl_autocorking_size if CONFIG_SYSCTL not set
> ---
>  net/smc/Makefile     |  3 ++-
>  net/smc/af_smc.c     | 15 ++++++---------
>  net/smc/smc_sysctl.c | 19 ++-----------------
>  net/smc/smc_sysctl.h |  9 +++++----
>  4 files changed, 15 insertions(+), 31 deletions(-)

Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested

thanks.

-- 
~Randy



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux