On 27.01.22 11:32, Janosch Frank wrote: > On 1/26/22 09:42, Nico Boehr wrote: >> We previously loaded into in1, but in1 is not filled during >> disassembly and hence always zero. This leads to an assertion failure: >> >> qemu-system-s390x: /home/nrb/qemu/include/tcg/tcg.h:654: temp_idx: >> Assertion `n >= 0 && n < tcg_ctx->nb_temps' failed.` >> >> Instead, use in2_la2_m64a to load from storage into in2 and pass that to >> the helper, which matches what we already do for SCKC. >> >> This fixes the SCK test I sent here under TCG: >> <https://www.spinics.net/lists/kvm/msg265169.html> >> >> Suggested-by: David Hildenbrand <david@xxxxxxxxxx> >> Signed-off-by: Nico Boehr <nrb@xxxxxxxxxxxxx> > > @David: Was this already broken when it was implemented? > I.e. do we want a "Fixes: 9dc67537 ("s390x/tcg: implement SET CLOCK ")" tag? That sounds about right. -- Thanks, David / dhildenb
