Re: [PATCH v5 4/6] module: strip the signature marker in the verification function.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Michal Suchanek <msuchanek@xxxxxxx>, David Howells <dhowells@xxxxxxxxxx>
Subject: Re: [PATCH v5 4/6] module: strip the signature marker in the verification function.
From: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Date: Tue, 25 Jan 2022 12:23:51 -0800
Cc: keyrings@xxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, linux-integrity@xxxxxxxxxxxxxxx, kexec@xxxxxxxxxxxxxxxxxxx, Philipp Rudo <prudo@xxxxxxxxxx>, Mimi Zohar <zohar@xxxxxxxxxxxxx>, Nayna <nayna@xxxxxxxxxxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, linux-s390@xxxxxxxxxxxxxxx, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Lakshmi Ramasubramanian <nramas@xxxxxxxxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Jessica Yu <jeyu@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Hari Bathini <hbathini@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, Frank van der Linden <fllinden@xxxxxxxxxx>, Thiago Jung Bauermann <bauerman@xxxxxxxxxxxxx>, Daniel Axtens <dja@xxxxxxxxxx>, buendgen@xxxxxxxxxx, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Dmitry Kasatkin <dmitry.kasatkin@xxxxxxxxx>, James Morris <jmorris@xxxxxxxxx>, "Serge E. Hallyn" <serge@xxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, Baoquan He <bhe@xxxxxxxxxx>, linux-security-module@xxxxxxxxxxxxxxx
In-reply-to: <96d29773b9ef418a71b1d8bbfd0a456a0f996ec6.1641900831.git.msuchanek@suse.de>
References: <cover.1641900831.git.msuchanek@suse.de> <96d29773b9ef418a71b1d8bbfd0a456a0f996ec6.1641900831.git.msuchanek@suse.de>

On Tue, Jan 11, 2022 at 12:37:46PM +0100, Michal Suchanek wrote:
> It is stripped by each caller separately.
> 
> Note: this changes the error for kexec_file from EKEYREJECTED to ENODATA
> when the signature marker is missing.
> 
> Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>
> ---
> v3: - Philipp Rudo <prudo@xxxxxxxxxx>: Update the commit with note about
>       change of raturn value
>     - the module_signature.h is now no longer needed for kexec_file

Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>

  Luis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH v5 0/6] KEXEC_SIG with appended signature
  - From: Michal Suchanek
- [PATCH v5 4/6] module: strip the signature marker in the verification function.
  - From: Michal Suchanek

Prev by Date: Re: [PATCH v5 3/6] kexec_file: Don't opencode appended signature verification.
Next by Date: Re: [PATCH v5 5/6] module: Use key_being_used_for for log messages in verify_appended_signature
Previous by thread: [PATCH v5 4/6] module: strip the signature marker in the verification function.
Next by thread: [PATCH v5 2/6] powerpc/kexec_file: Add KEXEC_SIG support.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite Info] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Linux Media] [Device Mapper]