On 2022/1/20 22:22, Tony Lu wrote:>> #include "smc_ib.h" >> >> -#define SMC_RMBS_PER_LGR_MAX 255 /* max. # of RMBs per link group */ >> +#define SMC_RMBS_PER_LGR_MAX 32 /* max. # of RMBs per link group. Correspondingly, >> + * SMC_WR_BUF_CNT should not be less than 2 * >> + * SMC_RMBS_PER_LGR_MAX, since every connection at >> + * least has two rq/sq credits in average, otherwise >> + * may result in waiting for credits in sending process. >> + */ > > This gives a fixed limit for per link group connections. Using tunable > knobs to control this for different workload would be better. It also > reduce the completion of free slots in the same link group and link. > It is a good idea, but I find a patch (https://lore.kernel.org/linux-s390/20220114054852.38058-7-tonylu@xxxxxxxxxxxxxxxxx/) where you have already done this idea.
