> > > r_type = ELF64_R_TYPE(relas[i].r_info); > > > - arch_kexec_do_relocs(r_type, loc, val, addr); > > > + ret = arch_kexec_do_relocs(r_type, loc, val, addr); > > > + if (ret) > > > + return -EINVAL; > > > > I'd prefer if this would return -ENOEXEC, just to be consistent with > > x86. And _maybe_ it would also make sense to print an error message, > > including the failing relocation type? > > sure, I'll update the return value to -ENOEXEC. > > About the error message, I didn't add it on purpose as none of the > other error cases print one. For consistency I would add one for those > cases as well. Any objections? No objections at all. This sounds good! Thanks, Heiko
