On 22.11.2021 11:37, Vineeth Vijayan wrote:
> commit fa1a8c23eb7d ("s390: cio: Delay uevents for subchannels")
> introduced suppression of uevents for a subchannel until after it is
> clear that the subchannel would not be unregistered again
> immediately. This was done to avoid uevents being generated for I/O
> subchannels with no valid device, which can happen on LPAR.
>
> However, this also has some drawbacks: All subchannel drivers need to
> manually remove the uevent suppression and generate an ADD uevent as
> soon as they are sure that the subchannel will stay around. This misses
> out on all uevents that are not the initial ADD uevent that would be
> generated while uevents are suppressed; for example, all subchannels
> were missing the BIND uevent.
>
> As uevents being generated even for I/O subchannels without an
> operational device turned out to be not as bad as missing uevents and
> complicating the code flow, let's remove uevent suppression for
> subchannel
>
> Signed-off-by: Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>
> [cohuck@xxxxxxxxxx: modified changelog]
Looks good to me!
Reviewed-by: Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>
Regards,
Peter
--
Peter Oberparleiter
Linux on Z Development - IBM Germany
