Re: [PATCH] s390: replace snprintf in show functions with sysfs_emit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 20, 2021 at 04:44:01PM +0200, Stefan Haberland wrote:
> Am 15.10.21 um 08:50 schrieb Qing Wang:
> > show() must not use snprintf() when formatting the value to be
> > returned to user space.
> > 
> > Fix the coccicheck warnings:
> > WARNING: use scnprintf or sprintf.
> > 
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> > 
> > Signed-off-by: Qing Wang <wangqing@xxxxxxxx>
> > ---
> >   drivers/s390/block/dasd_devmap.c | 74 ++++++++++++++++++++--------------------
> > 
> 
> Thanks for the DASD changes. While I am totally fine with the change itself
> I agree with Joe's remark.
> Would you like to improve your patch? Otherwise I can add a small follow on
> patch. Just let me know.

I translated this to Acked-by. Please provide an addon patch if you
want to have this changed.
Applied, thanks!



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux