On Thu, Oct 07 2021, Halil Pasic <pasic@xxxxxxxxxxxxx> wrote: > On Thu, 07 Oct 2021 17:25:52 +0200 > Cornelia Huck <cohuck@xxxxxxxxxx> wrote: > >> On Thu, Oct 07 2021, Halil Pasic <pasic@xxxxxxxxxxxxx> wrote: >> >> > On Thu, 07 Oct 2021 13:52:24 +0200 >> > Cornelia Huck <cohuck@xxxxxxxxxx> wrote: >> > >> >> On Wed, Oct 06 2021, Halil Pasic <pasic@xxxxxxxxxxxxx> wrote: >> >> >> >> > The virtio specification virtio-v1.1-cs01 states: "Transitional devices >> >> > MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not >> >> > been acknowledged by the driver." This is exactly what QEMU as of 6.1 >> >> > has done relying solely on VIRTIO_F_VERSION_1 for detecting that. >> >> > >> >> > However, the specification also says: "... driver MAY read (but MUST NOT >> >> > write) the device-specific configuration fields to check that it can >> >> > support the device ..." before setting FEATURES_OK. >> >> >> >> Suggest to put the citations from the spec into quotes, so that they are >> >> distinguishable from the rest of the text. >> > >> > For the record: I basically took Michael's description, the one which you >> > said you prefer, with some minor changes. >> >> Well I did look at what the text said, not the details in the formatting... >> >> > >> > This is one of the changes, which renders this a paraphrase and not a >> > quote. Michael didn't use quotation marks so I was not sure it is was >> > a word by word quote anyway. It was. But the spec depends on "During this >> > step" which does not make any sense without the context. That is why I made >> > the end of step explicit. >> >> I still think that would be nicer while using some quotation marks, even >> if you are just doing a partial quote. >> >> In the first paragraph, however, we really should mark the quote >> properly. It gave me a stop when I first read it. > > I've added in some quotation marks and ellipsis marks. Does that look > good for you? Yep, works for me.
