On Mon, Oct 04 2021, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: > On Mon, Oct 04, 2021 at 05:45:06PM +0200, Cornelia Huck wrote: >> On Mon, Oct 04 2021, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: >> >> > On Mon, Oct 04, 2021 at 04:27:23PM +0200, Cornelia Huck wrote: >> >> On Mon, Oct 04 2021, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: >> >> >> >> > Do we want to also add explanation that features can be >> >> > changed until FEATURES_OK? >> >> >> >> I always considered that to be implict, as feature negotiation is not >> >> over until we have FEATURES_OK. Not sure whether we need an extra note. >> > >> > Well Halil here says once you set a feature bit you can't clear it. >> > So maybe not ... >> >> Ok, so what about something like >> >> "If FEATURES_OK is not set, the driver MAY change the set of features it >> accepts." >> >> in the device initialization section? > > Maybe "as long as". However Halil implied that some features are not > turned off properly if that happens. Halil could you pls provide > some examples? Yes, "as long as" sounds better.
