On Fri, Sep 10 2021, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Thu, Sep 09, 2021 at 04:38:41PM -0300, Jason Gunthorpe wrote:
>> +
>> + private = kzalloc(sizeof(*private), GFP_KERNEL | GFP_DMA);
>> + if (!private)
>> + return ERR_PTR(-ENOMEM);
>
> Nit: there is no need to add GFP_KERNEL when using GFP_DMA.
>
> Also a question to the s390 maintainers: why do we need 31-bit
> addressability for the main private data structure?
I don't think we need it anymore since c98e16b2fa12 ("s390/cio: Convert
ccw_io_region to pointer") and probably should just drop the GFP_DMA.
