From: Jing Yangyang <jing.yangyang@xxxxxxxxxx> ./arch/s390/include/asm/bitops.h:191:9-10:WARNING:return of 0/1 in function 'arch_test_and_set_bit_lock' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Reported-by: Zeal Robot <zealci@xxxxxxxxxx> Signed-off-by: Jing Yangyang <jing.yangyang@xxxxxxxxxx> --- arch/s390/include/asm/bitops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/include/asm/bitops.h b/arch/s390/include/asm/bitops.h index f7cefdd..1d40630 100644 --- a/arch/s390/include/asm/bitops.h +++ b/arch/s390/include/asm/bitops.h @@ -188,7 +188,7 @@ static inline bool arch_test_and_set_bit_lock(unsigned long nr, volatile unsigned long *ptr) { if (arch_test_bit(nr, ptr)) - return 1; + return true; return arch_test_and_set_bit(nr, ptr); } -- 1.8.3.1