On Wed, Jul 28, 2021 at 03:08:08PM +0200, Arnd Bergmann wrote: > > @@ -17,6 +15,7 @@ config VFIO_PCI_INTX > > > > config VFIO_PCI > > tristate "Generic VFIO support for any PCI device" > > + select VFIO_PCI_CORE > > help > > Support for the generic PCI VFIO bus driver which can connect any > > PCI device to the VFIO framework. > > @@ -50,6 +49,7 @@ endif > > config MLX5_VFIO_PCI > > tristate "VFIO support for MLX5 PCI devices" > > depends on MLX5_CORE > > + select VFIO_PCI_CORE > > help > > These two now have to get a 'depends on MMU' if they don't already inherit > that from elsewhere. Just so I understand this remark properly, I added this at the top of the file: if PCI && MMU And when I check CONFIG_MLX5_VFIO_PCI I see: Defined at drivers/vfio/pci/Kconfig:51 Prompt: VFIO support for MLX5 PCI devices Depends on: VFIO [=y] && PCI [=y] && MMU [=y] && MLX5_CORE [=y] So this is doing what you mean, right? I've attached the whole thing below just for clarity Thanks, Jason # SPDX-License-Identifier: GPL-2.0-only if PCI && MMU config VFIO_PCI_CORE tristate select VFIO_VIRQFD select IRQ_BYPASS_MANAGER help Support for using PCI devices with VFIO. config VFIO_PCI_MMAP def_bool y if !S390 config VFIO_PCI_INTX def_bool y if !S390 menu "VFIO PCI Drivers" config VFIO_PCI tristate "Generic VFIO support for any PCI device" select VFIO_PCI_CORE help Support for the generic PCI VFIO bus driver which can connect any PCI device to the VFIO framework. If you don't know what to do here, say N. if VFIO_PCI config VFIO_PCI_VGA bool "Generic VFIO PCI support for VGA devices" depends on X86 && VGA_ARB help Support for VGA extension to VFIO PCI. This exposes an additional region on VGA devices for accessing legacy VGA addresses used by BIOS and generic video drivers. If you don't know what to do here, say N. config VFIO_PCI_IGD bool "Generic VFIO PCI extensions for Intel graphics (GVT-d)" depends on X86 default y help Support for Intel IGD specific extensions to enable direct assignment to virtual machines. This includes exposing an IGD specific firmware table and read-only copies of the host bridge and LPC bridge config space. To enable Intel IGD assignment through vfio-pci, say Y. endif config MLX5_VFIO_PCI tristate "VFIO support for MLX5 PCI devices" depends on MLX5_CORE select VFIO_PCI_CORE help This provides a PCI support for MLX5 devices using the VFIO framework. The device specific driver supports suspend/resume of the MLX5 device. If you don't know what to do here, say N. endmenu endif
