On 29/06/2021 15.33, Janosch Frank wrote:
These structs have largely been copied from the kernel so they still
have the old uint short types which we want to avoid in favor of the
uint*_t ones.
Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
---
lib/s390x/asm/uv.h | 142 +++++++++++++++++++++++----------------------
1 file changed, 72 insertions(+), 70 deletions(-)
diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h
index dc3e02d..96a2a7e 100644
--- a/lib/s390x/asm/uv.h
+++ b/lib/s390x/asm/uv.h
@@ -12,6 +12,8 @@
#ifndef _ASMS390X_UV_H_
#define _ASMS390X_UV_H_
+#include <stdint.h>
+
#define UVC_RC_EXECUTED 0x0001
#define UVC_RC_INV_CMD 0x0002
#define UVC_RC_INV_STATE 0x0003
@@ -68,73 +70,73 @@ enum uv_cmds_inst {
};
struct uv_cb_header {
- u16 len;
- u16 cmd; /* Command Code */
- u16 rc; /* Response Code */
- u16 rrc; /* Return Reason Code */
+ uint16_t len;
+ uint16_t cmd; /* Command Code */
+ uint16_t rc; /* Response Code */
+ uint16_t rrc; /* Return Reason Code */
} __attribute__((packed)) __attribute__((aligned(8)));
Hmm, for files that are more or less a copy from the corresponding kernel
header, I'm not sure whether it makes sense to convert them to the stdint.h
types? It might be better to keep the kernel types so that updates to this
header can be ported more easily to the kvm-unit-tests later?
Thomas
