Re: [PATCH] virtio/s390: get rid of open-coded kvm hypercall

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 21, 2021 at 05:27:00PM +0200, Cornelia Huck wrote:
> On Mon, Jun 21 2021, Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:
> 
> > do_kvm_notify() and __do_kvm_notify() are an (exact) open-coded variant
> > of kvm_hypercall3(). Therefore simply make use of kvm_hypercall3(),
> > and get rid of duplicated code.
> >
> > Signed-off-by: Heiko Carstens <hca@xxxxxxxxxxxxx>
> > ---
> >  drivers/s390/virtio/virtio_ccw.c | 30 ++++--------------------------
> >  1 file changed, 4 insertions(+), 26 deletions(-)
> >
> 
> Hm, I wonder why I didn't use kvm_hypercall3 in the first place. It's in
> a header, and therefore should be independent of kvm being configured.
> 
> I don't think there's anything else virtio-ccw in flight at the moment,
> so maybe you can apply this one directly?

Yes, sure.

> Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>

Thank you!



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux