On 09/06/2021 17:47, Cornelia Huck wrote: > On Wed, Jun 09 2021, Laurent Vivier <lvivier@xxxxxxxxxx> wrote: > >> On 09/06/2021 16:37, Cornelia Huck wrote: >>> The assembler.h files were the only ones not already following >>> the convention. >>> >>> Signed-off-by: Cornelia Huck <cohuck@xxxxxxxxxx> >>> --- >>> lib/arm/asm/assembler.h | 6 +++--- >>> lib/arm64/asm/assembler.h | 6 +++--- >>> 2 files changed, 6 insertions(+), 6 deletions(-) >> >> What about lib/arm/io.h? > > It didn't have a guard yet, so I didn't touch it. > >> >> I think you can remove the guard from >> >> lib/arm/asm/memory_areas.h >> >> as the other files including directly a header doesn't guard it. > > I see other architectures doing that, though. I guess it doesn't hurt, > but we can certainly also remove it. Other opinions? It doesn't hurt to remove it but I think what is important is to have the same rule everywhere. Thanks, Laurent
