XXXXX Alexander Egorenkov <egorenar@xxxxxxxxxxxxx> XXX Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx> XXX linux-s390@xxxxxxxxxxxxxxx, fontaine.fabrice@xxxxxxxxx XXX XXXXXXXX Re: [PATCH] arch/s390: disable SSP when needed XXXXXXXXXXXX <20210510053133.1220167-1-fontaine.fabrice@xxxxxxxxx> (message XXXX Fabrice Fontaine on Mon, 10 May 2021 07:31:33 +0200) XXXXXXXXXXXX XXXXX Tue, 25 May 2021 08:29:33 +0200 XXXXXXXXXXX <875yz7z5pu.fsf@xxxxxxxxxxxxxxxxxxxx> XXXXXXXXXXXXX 1.0 XXXXXXXXXXXXX text/plain XXXXXXX Fontaine <fontaine.fabrice@xxxxxxxxx> writes: X Though -nostdlib is passed in PURGATORY_LDFLAGS and -ffreestanding in X KBUILD_CFLAGS_DECOMPRESSOR, -fno-stack-protector must also be passed to X avoid linking errors related to undefined references to X '__stack_chk_guard' and '__stack_chk_fail' if toolchain enforces X -fstack-protector. X X Fixes: X - https://gitlab.com/kubu93/buildroot/-/jobs/1247043361 X X Signed-off-by: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx> X --- X arch/s390/Makefile | 1 + X arch/s390/purgatory/Makefile | 1 + X 2 files changed, 2 insertions(+) X X diff --git a/arch/s390/Makefile b/arch/s390/Makefile X index e443ed9947bd..098abe3a56f3 100644 X --- a/arch/s390/Makefile X +++ b/arch/s390/Makefile X @@ -28,6 +28,7 @@ KBUILD_CFLAGS_DECOMPRESSOR += XXXXXXXXXXXXXXXXXXXXXXXXXX -D__NO_FORTIFY X KBUILD_CFLAGS_DECOMPRESSOR += -fno-delete-null-pointer-checks -msoft-float -mbackchain X KBUILD_CFLAGS_DECOMPRESSOR += -fno-asynchronous-unwind-tables X KBUILD_CFLAGS_DECOMPRESSOR += -ffreestanding X +KBUILD_CFLAGS_DECOMPRESSOR += -fno-stack-protector X KBUILD_CFLAGS_DECOMPRESSOR += $(call cc-disable-warning, address-of-packed-member) X KBUILD_CFLAGS_DECOMPRESSOR += $(if $(CONFIG_DEBUG_INFO),-g) X KBUILD_CFLAGS_DECOMPRESSOR += $(if $(CONFIG_DEBUG_INFO_DWARF4), $(call cc-option, -gdwarf-4,)) X diff --git a/arch/s390/purgatory/Makefile b/arch/s390/purgatory/Makefile X index c57f8c40e992..21c4ebe29b9a 100644 X --- a/arch/s390/purgatory/Makefile X +++ b/arch/s390/purgatory/Makefile X @@ -24,6 +24,7 @@ KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes X KBUILD_CFLAGS += -Wno-pointer-sign -Wno-sign-compare X KBUILD_CFLAGS += -fno-zero-initialized-in-bss -fno-builtin -ffreestanding X KBUILD_CFLAGS += -c -MD -Os -m64 -msoft-float -fno-common X +KBUILD_CFLAGS += -fno-stack-protector X KBUILD_CFLAGS += $(CLANG_FLAGS) X KBUILD_CFLAGS += $(call cc-option,-fno-PIE) X KBUILD_AFLAGS := $(filter-out -DCC_USING_EXPOLINE,$(KBUILD_AFLAGS)) XX Fabrice, XXXX looks good to me. XXXXX you for the patch. XXXXXXXXXXXX Alexander Egorenkov <egorenar@xxxxxxxxxxxxx> Tested-by: Alexander Egorenkov <egorenar@xxxxxxxxxxxxx> Regards Alex
