On 5/19/21 12:17 PM, Cornelia Huck wrote:
> On Wed, 19 May 2021 08:26:47 +0000
> Janosch Frank <frankja@xxxxxxxxxxxxx> wrote:
>
>> Lets grab more of the feature bits from SCLP read info so we can use
>
> s/Lets/Let's/ :)
Sigh
>
>> them in the cpumodel tests.
>>
>> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
>> Reviewed-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
>> ---
>> lib/s390x/sclp.c | 20 ++++++++++++++++++++
>> lib/s390x/sclp.h | 38 +++++++++++++++++++++++++++++++++++---
>> 2 files changed, 55 insertions(+), 3 deletions(-)
>
> (...)
>
> Maybe add
>
> /* bit number within a certain byte */
Sure
>
>> +#define SCLP_FEAT_85_BIT_GSLS 7
>> +#define SCLP_FEAT_98_BIT_KSS 0
>> +#define SCLP_FEAT_116_BIT_64BSCAO 7
>> +#define SCLP_FEAT_116_BIT_CMMA 6
>> +#define SCLP_FEAT_116_BIT_ESCA 3
>> +#define SCLP_FEAT_117_BIT_PFMFI 6
>> +#define SCLP_FEAT_117_BIT_IBS 5
>> +
>> typedef struct ReadInfo {
>> SCCBHeader h;
>> uint16_t rnmax;
>
> Acked-by: Cornelia Huck <cohuck@xxxxxxxxxx>
>
Thanks!
