Re: [PATCH 12/14] d_path: prepend_path(): lift the inner loop into a new helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 19, 2021 at 12:48:59AM +0000, Al Viro wrote:
> ... and leave the rename_lock/mount_lock handling in prepend_path()
> itself

...

> +			if (!IS_ERR_OR_NULL(mnt_ns) && !is_anon_ns(mnt_ns))
> +				return 1;	// absolute root
> +			else
> +				return 2;	// detached or not attached yet

Would it be slightly better to read

			if (IS_ERR_OR_NULL(mnt_ns) || is_anon_ns(mnt_ns))
				return 2;	// detached or not attached yet
			else
				return 1;	// absolute root

?

Oh, I have noticed that it's in the original piece of code (perhaps separate
change if we ever need it?).


-- 
With Best Regards,
Andy Shevchenko





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux