Re: [kvm-unit-tests PATCH 4/4] s390x: cpumodel: FMT2 SCLP implies test

[David Hildenbrand <david@xxxxxxxxxx>]

On 10.05.21 17:00, Janosch Frank wrote:
> The sie facilities require sief2 to also be enabled, so lets check if
> that's the case.
>
> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
> ---
>   s390x/cpumodel.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/s390x/cpumodel.c b/s390x/cpumodel.c
> index 619c3dc7..67bb6543 100644
> --- a/s390x/cpumodel.c
> +++ b/s390x/cpumodel.c
> @@ -56,12 +56,24 @@ static void test_sclp_features_fmt4(void)
>   	report_prefix_pop();
>   }
>   
> +static void test_sclp_features_fmt2(void)
> +{
> +	if (sclp_facilities.has_sief2)
> +		return;
> +
> +	report_prefix_push("!sief2 implies");
> +	test_sclp_missing_sief2_implications();
> +	report_prefix_pop();
> +}
> +
>   static void test_sclp_features(void)
>   {
>   	report_prefix_push("sclp");
>   
>   	if (uv_os_is_guest())
>   		test_sclp_features_fmt4();
> +	else
> +		test_sclp_features_fmt2();
>   
>   	report_prefix_pop();
>   }

I'd fold that into the previous patch

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb