On Mon, May 03, 2021 at 02:12:44PM +0200, David Hildenbrand wrote: > The PoP documents: > 134: The vector packed decimal facility is installed in the > z/Architecture architectural mode. When bit 134 is > one, bit 129 is also one. > 135: The vector enhancements facility 1 is installed in > the z/Architecture architectural mode. When bit 135 > is one, bit 129 is also one. > > Looks like we confuse the vector enhancements facility 1 ("EXT") with the > Vector packed decimal facility ("BCD"). Let's fix the facility checks. > > Detected while working on QEMU/tcg z14 support and only unlocking > the vector enhancements facility 1, but not the vector packed decimal > facility. > > Fixes: 2583b848cad0 ("s390: report new vector facilities") > Cc: Heiko Carstens <hca@xxxxxxxxxxxxx> > Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx> > Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx> > Cc: Sven Schnelle <svens@xxxxxxxxxxxxx> > Cc: Alexander Egorenkov <egorenar@xxxxxxxxxxxxx> > Cc: Niklas Schnelle <schnelle@xxxxxxxxxxxxx> > Cc: Janosch Frank <frankja@xxxxxxxxxxxxx> > Cc: linux-s390@xxxxxxxxxxxxxxx > Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> > --- > arch/s390/kernel/setup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks!