On Tue, 23 Mar 2021 14:55:35 -0300 Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > The driver core standard is to pass in the properly typed object, the > properly typed attribute and the buffer data. It stems from the root > kobject method: > > ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *attr,..) > > Each subclass of kobject should provide their own function with the same > signature but more specific types, eg struct device uses: > > ssize_t (*show)(struct device *dev, struct device_attribute *attr,..) > > In this case the existing signature is: > > ssize_t (*show)(struct kobject *kobj, struct device *dev,..) > > Where kobj is a 'struct mdev_type *' and dev is 'mdev_type->parent->dev'. > > Change the mdev_type related sysfs attribute functions to: > > ssize_t (*show)(struct mdev_type *mtype, struct mdev_type_attribute *attr,..) > > In order to restore type safety and match the driver core standard > > There are no current users of 'attr', but if it is ever needed it would be > hard to add in retroactively, so do it now. > > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx> > --- > drivers/gpu/drm/i915/gvt/gvt.c | 21 +++++++++++---------- > drivers/s390/cio/vfio_ccw_ops.c | 15 +++++++++------ > drivers/s390/crypto/vfio_ap_ops.c | 12 +++++++----- > drivers/vfio/mdev/mdev_core.c | 14 ++++++++++++-- > drivers/vfio/mdev/mdev_sysfs.c | 11 ++++++----- > include/linux/mdev.h | 11 +++++++---- > samples/vfio-mdev/mbochs.c | 26 +++++++++++++++----------- > samples/vfio-mdev/mdpy.c | 24 ++++++++++++++---------- > samples/vfio-mdev/mtty.c | 18 +++++++++--------- > 9 files changed, 90 insertions(+), 62 deletions(-) Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>
