On 23/03/2021 03:05, zuoqilin1@xxxxxxx wrote:
> From: zuoqilin <zuoqilin@xxxxxxxxxx>
>
> Simplify the return expression of smc_ism_signal_shutdown().
>
> Signed-off-by: zuoqilin <zuoqilin@xxxxxxxxxx>
> ---
> net/smc/smc_ism.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/smc/smc_ism.c b/net/smc/smc_ism.c
> index 9c6e958..c3558cc 100644
> --- a/net/smc/smc_ism.c
> +++ b/net/smc/smc_ism.c
> @@ -344,7 +344,6 @@ static void smcd_handle_sw_event(struct smc_ism_event_work *wrk)
>
> int smc_ism_signal_shutdown(struct smc_link_group *lgr)
> {
> - int rc;
> union smcd_sw_event_info ev_info;
>
> if (lgr->peer_shutdown)
> @@ -353,11 +352,10 @@ int smc_ism_signal_shutdown(struct smc_link_group *lgr)
> memcpy(ev_info.uid, lgr->id, SMC_LGR_ID_SIZE);
> ev_info.vlan_id = lgr->vlan_id;
> ev_info.code = ISM_EVENT_REQUEST;
> - rc = lgr->smcd->ops->signal_event(lgr->smcd, lgr->peer_gid,
> + return lgr->smcd->ops->signal_event(lgr->smcd, lgr->peer_gid,
> ISM_EVENT_REQUEST_IR,
> ISM_EVENT_CODE_SHUTDOWN,
> ev_info.info);
I agree with the code change but after I applied your patch the 3 lines above
are no longer correctly indented, please correct that and resend the patch.
Thanks.
> - return rc;
> }
>
> /* worker for SMC-D events */
>
--
Karsten
(I'm a dude)
