On 1/20/21 2:07 PM, Anshuman Khandual wrote: > > > On 1/19/21 7:10 PM, Oscar Salvador wrote: >> On Tue, Jan 19, 2021 at 02:33:03PM +0100, David Hildenbrand wrote: >>> Minor thing, we should make up our mind if we want to call stuff >>> internally "memhp_" or "mhp". I prefer the latter, because it is shorter. >> >> I would rather use the latter as well. I used that in [1]. > > Okay, will change all that is 'memhp' as 'mhp' instead. > >> MEMHP_MERGE_RESOURCE should be renamed if we agree on that. >> >> [1] https://patchwork.kernel.org/project/linux-mm/cover/20201217130758.11565-1-osalvador@xxxxxxx/ >> While replacing 'memhp' as 'mhp' in this series, noticed there are some more 'memhp' scattered around the code from earlier. A mix of both 'memhp' and 'mhp' might not be a good idea. Hence should we just change these remaining 'memhp' as 'mhp' as well and possibly also MEMHP_MERGE_RESOURCE as suggested earlier, in a subsequent clean up patch ? Would there be a problem with memhp_default_state being a command line parameter ? >From a tree wide search - Documentation/admin-guide/kernel-parameters.txt: memhp_default_state=online/offline drivers/base/memory.c:int memhp_online_type_from_str(const char *str) drivers/base/memory.c: const int online_type = memhp_online_type_from_str(buf); drivers/base/memory.c: online_type_to_str[memhp_default_online_type]); drivers/base/memory.c: const int online_type = memhp_online_type_from_str(buf); drivers/base/memory.c: memhp_default_online_type = online_type; include/linux/memory_hotplug.h:extern int memhp_online_type_from_str(const char *str); include/linux/memory_hotplug.h:extern int memhp_default_online_type; mm/memory_hotplug.c:int memhp_default_online_type = MMOP_OFFLINE; mm/memory_hotplug.c:int memhp_default_online_type = MMOP_ONLINE; mm/memory_hotplug.c:static int __init setup_memhp_default_state(char *str) mm/memory_hotplug.c: const int online_type = memhp_online_type_from_str(str); mm/memory_hotplug.c: memhp_default_online_type = online_type; mm/memory_hotplug.c:__setup("memhp_default_state=", setup_memhp_default_state); mm/memory_hotplug.c: mem->online_type = memhp_default_online_type; mm/memory_hotplug.c: if (memhp_default_online_type != MMOP_OFFLINE)
