On Wed, Dec 02, 2020 at 05:35:21PM -0500, Tejun Heo wrote: > On Tue, Dec 01, 2020 at 05:54:15PM +0100, Christoph Hellwig wrote: > > Hi Jens, > > > > this series switches back from storing the gendisk + partno to storing > > a block_device pointer in struct bio. The reason is two fold: for one > > the new struct block_device actually is always available, removing the > > need to avoid originally. Second the merge struct block_device is much > > more useful than the old one, as storing it avoids the need for looking > > up what used to be hd_struct during partition remapping and I/O > > accounting. > > > > Note that this series depends on the posted but not merged > > "block tracepoint cleanups" series. > > I'm late but everything looks good to me. So much better than the mess we > had before. Thank you. > > The only thing I noticed is that blkdev_get_no_open() can now use > kobject_get() instead of kobject_get_unless_zero() as bdev lookup is > synchronously disabled before device_del(). Oops, sorry, this was supposed to be a reply to the earlier hd_struct removal patchset. Reviewing this patchset now. Thanks. -- tejun
