On 2020-11-20 10:05:45 [+0200], Julian Wiedmann wrote:
> > diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c
> > index a3a74ebfee635..0cb130c280031 100644
> > --- a/drivers/s390/net/ctcm_main.c
> > +++ b/drivers/s390/net/ctcm_main.c
> > @@ -666,24 +666,16 @@ static int ctcmpc_transmit_skb(struct channel *ch, struct sk_buff *skb)
> > if ((fsm_getstate(ch->fsm) != CTC_STATE_TXIDLE) || grp->in_sweep) {
> > spin_lock_irqsave(&ch->collect_lock, saveflags);
> > refcount_inc(&skb->users);
> > - p_header = kmalloc(PDU_HEADER_LENGTH, gfp_type());
> > -
> > - if (!p_header) {
> > - spin_unlock_irqrestore(&ch->collect_lock, saveflags);
> > - goto nomem_exit;
> > - }
> >
> > + p_header = skb_push(skb, PDU_HEADER_LENGTH);
> > p_header->pdu_offset = skb->len;
>
> I mentioned this in my reply to v1 - here we now need to adjust skb->len
> for the pushed length. Will fix up while applying (also below).
I'm sorry. It took me a while to understand what you meant and then I
forgot about it while I was here.
Thank you for taking care of it.
Sebastian
