Re: [PATCH 1/3] s390/vmem: remove redundant check

[David Hildenbrand <david@xxxxxxxxxx>]

On 10.11.20 10:36, Alexander Gordeev wrote:
> Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>
> ---
>   arch/s390/mm/vmem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/mm/vmem.c b/arch/s390/mm/vmem.c
> index b239f2ba93b09..56ab9bb770f3a 100644
> --- a/arch/s390/mm/vmem.c
> +++ b/arch/s390/mm/vmem.c
> @@ -223,7 +223,7 @@ static int __ref modify_pmd_table(pud_t *pud, unsigned long addr,
>   		if (!add) {
>   			if (pmd_none(*pmd))
>   				continue;
> -			if (pmd_large(*pmd) && !add) {
> +			if (pmd_large(*pmd)) {
>   				if (IS_ALIGNED(addr, PMD_SIZE) &&
>   				    IS_ALIGNED(next, PMD_SIZE)) {
>   					if (!direct)

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb