On 5/25/20 9:12 PM, Thomas Huth wrote: > On 18/05/2020 18.07, Pierre Morel wrote: >> First step for testing the channel subsystem is to enumerate the css and >> retrieve the css devices. >> >> This tests the success of STSCH I/O instruction, we do not test the >> reaction of the VM for an instruction with wrong parameters. >> >> Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx> >> --- >> s390x/Makefile | 1 + >> s390x/css.c | 89 +++++++++++++++++++++++++++++++++++++++++++++ >> s390x/unittests.cfg | 4 ++ >> 3 files changed, 94 insertions(+) >> create mode 100644 s390x/css.c > [...] >> diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg >> index 07013b2..a436ec0 100644 >> --- a/s390x/unittests.cfg >> +++ b/s390x/unittests.cfg >> @@ -83,3 +83,7 @@ extra_params = -m 1G >> [sclp-3g] >> file = sclp.elf >> extra_params = -m 3G >> + >> +[css] >> +file = css.elf >> +extra_params =-device ccw-pong > > I gave your patch series a try on a normal upstream QEMU (that does not > have the ccw-pong device yet), and the css test of course fails there, > since QEMU bails out with: > > -device ccw-pong: 'ccw-pong' is not a valid device model name > > This is unfortunate - I think we likely have to deal with QEMUs for > quite a while that do not have this device enabled. Could you maybe add > some kind of check to the kvm-unit-tests scripts that only run a test if > a given device is available, and skip the test otherwise? > > Thomas > Could we for now remove it from unittests.cfg and let Pierre come up with a solution without delaying this whole series? I expect changes to run_tests.sh to attract a rather long discussion...
Attachment:
signature.asc
Description: OpenPGP digital signature
