On 2020-05-14 14:03, Cornelia Huck wrote:
On Fri, 24 Apr 2020 12:45:47 +0200
Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote:
These are the include and library utilities for the css tests patch
series.
"Provide some definitions and library routines that can be used by
tests targeting the channel subsystem."
?
Definitively better. Thanks, I will update.
Debug function can be activated by defining DEBUG_CSS before the
inclusion of the css.h header file.
Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx>
---
lib/s390x/css.h | 256 +++++++++++++++++++++++++++++++++++++++++++
lib/s390x/css_dump.c | 157 ++++++++++++++++++++++++++
2 files changed, 413 insertions(+)
create mode 100644 lib/s390x/css.h
create mode 100644 lib/s390x/css_dump.c
(...)
diff --git a/lib/s390x/css_dump.c b/lib/s390x/css_dump.c
new file mode 100644
index 0000000..2f33fab
--- /dev/null
+++ b/lib/s390x/css_dump.c
@@ -0,0 +1,157 @@
+/*
+ * Channel subsystem structures dumping
+ *
+ * Copyright (c) 2020 IBM Corp.
+ *
+ * Authors:
+ * Pierre Morel <pmorel@xxxxxxxxxxxxx>
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2.
+ *
+ * Description:
+ * Provides the dumping functions for various structures used by subchannels:
+ * - ORB : Operation request block, describes the I/O operation and points to
+ * a CCW chain
+ * - CCW : Channel Command Word, describes the data and flow control
"describes the command, data, and flow control" ?
OK, thanks
+ * - IRB : Interuption response Block, describes the result of an operation
s/operation/operation;/
? I do not understand, do you want a ";" at the end of "operation"
Isn't it a typo error?
+ * holds a SCSW and model-dependent data.
+ * - SCHIB: SubCHannel Information Block composed of:
+ * - SCSW: SubChannel Status Word, status of the channel.
+ * - PMCW: Path Management Control Word
+ * You need the QEMU ccw-pong device in QEMU to answer the I/O transfers.
+ */
(...)
Otherwise, looks good.
Thanks,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
