On 2020-04-27 15:14, Janosch Frank wrote:
On 4/24/20 12:45 PM, Pierre Morel wrote:
To test a write command with the SSCH instruction we need a QEMU device,
with control unit type 0xC0CA. The PONG device is such a device.
This type of device responds to PONG_WRITE requests by incrementing an
integer, stored as a string at offset 0 of the CCW data.
Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx>
+static void test_ping(void)
+{
+ int success, result;
+ int cnt = 0, max = 4;
+
+ if (senseid.cu_type != PONG_CU) {
+ report_skip("No PONG, no ping-pong");
"Device is not a pong device."
:( so far for poetry
+ return;
+ }
+
+ result = register_io_int_func(irq_io);
+ if (result) {
+ report(0, "Could not register IRQ handler");
+ return;
+ }
I'm not sure if it's worth checking the return values or even having a
check in register_io_int_func() in the first place.
I wait for reviewers/maintainers having already given their reviewed-by
to the interrupt registration patch to give their opinion.
Then I change it if needed.
Regards,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
