On Fri, 17 Apr 2020 04:29:53 +0200 Eric Farman <farman@xxxxxxxxxxxxx> wrote: > Here is a new pass at the channel-path handling code for vfio-ccw. > Changes from previous versions are recorded in git notes for each patch. > > I dropped the "Remove inline get_schid()" patch from this version. > When I made the change suggested in v2, it seemed rather frivolous and > better to just drop it for the time being. > > I suspect that patches 5 and 7 would be better squashed together, but I > have not done that here. For future versions, I guess. The result also might get a bit large. > > With this, and the corresponding QEMU series (to be posted momentarily), > applied I am able to configure off/on a CHPID (for example, by issuing > "chchp -c 0/1 xx" on the host), and the guest is able to see both the > events and reflect the updated path masks in its structures. Basically, this looks good to me (modulo my comments). One thing though that keeps coming up: do we need any kind of serialization? Can there be any confusion from concurrent reads from userspace, or are we sure that we always provide consistent data?