On Thu, Mar 26, 2020 at 12:07:44PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/s390/net/ism_drv.c:570:12: warning: unused function > 'ism_suspend' [-Wunused-function] > static int ism_suspend(struct device *dev) > ^ > drivers/s390/net/ism_drv.c:578:12: warning: unused function 'ism_resume' > [-Wunused-function] > static int ism_resume(struct device *dev) > ^ > 2 warnings generated. > > When CONFIG_PM is unset, SIMPLE_DEV_PM_OPS does not use the suspend or > resume functions. Power management was recently ripped out of s390 so > CONFIG_PM will never be set and these functions will always be unused. > > Remove them so that there is no more warning. > > Link: https://github.com/ClangBuiltLinux/linux/issues/950 > Fixes: 394216275c7d ("s390: remove broken hibernate / power management support") > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx> Thank you, however there was already an identical patch from Ursula which was missing on our branch. It's now there: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h=features&id=194f75706b86847d1b4237958f7d6bd7ea7baf42
