On Fri, 27 Mar 2020 11:39:54 +0100
Cornelia Huck <cohuck@xxxxxxxxxx> wrote:
> On Fri, 27 Mar 2020 11:23:33 +0100
> Christian Borntraeger <borntraeger@xxxxxxxxxx> wrote:
>
> > On 27.03.20 10:23, Christian Borntraeger wrote:
>
> > After the qemu patch discussion I would add
> >
> >
> > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
> > index 0e268b3d1591..ba8f9cbe4376 100644
> > --- a/Documentation/virt/kvm/api.rst
> > +++ b/Documentation/virt/kvm/api.rst
> > @@ -4680,6 +4680,12 @@ KVM_PV_ENABLE
> > command has succeeded, any CPU added via hotplug will become
> > protected during its creation as well.
> >
> > + Errors:
> > +
> > + ===== =============================
> > + EINTR an unmasked signal is pending
> > + ===== =============================
> > +
> > KVM_PV_DISABLE
> >
> > Deregister the VM from the Ultravisor and reclaim the memory that
> >
> >
> > and change the patch description to something like
> >
> >
> > s390/gmap: return proper error code on ksm unsharing
> >
> > If a signal is pending we might return -ENOMEM instead of -EINTR.
> > We should propagate the proper error during KSM unsharing.
> > unmerge_ksm_pages returns -ERESTARTSYS on signal_pending. This gets
> > translated by entry.S to -EINTR. It is important to get this error
> > code so that userspace can retry.
> >
> > Fixes: 3ac8e38015d4 ("s390/mm: disable KSM for storage key enabled pages")
> > Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxxxxxxx>
> > Reported-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx>
> > Tested-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx>
> > Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
> > Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> >
>
> LGTM
...well, if you add my
Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>
