Re: [PATCH net-next 01/11] s390/qeth: simplify RX buffer tracking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Julian Wiedmann <jwi@xxxxxxxxxxxxx>
Date: Tue, 24 Mar 2020 19:24:38 +0100

> +#define QDIO_ELEMENT_NO(buf, element)	(element - &buf->element[0])

Maybe this works, but I would strongly suggest against using a CPP
macro argument that is the same name for the singleton element on
the left branch of the expression as the struct member name on
the right side of the element.

Furthermore, as far as I can tell this is only used in one location
in the code, and for such a simple expression that is excessive.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux