On Wed, Mar 04, 2020 at 06:20:48AM +0530, afzal mohammed wrote: > request_irq() is preferred over setup_irq(). Invocations of setup_irq() > occur after memory allocators are ready. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed <afzal.mohd.ma@xxxxxxxxx> > --- > Hi s390 maintainers, > > if okay w/ this change, please consider taking it thr' your tree, else please > let me know. > > Regards > afzal Applied. However I changed the pr_err invocations to panic, since it doesn't make sense to continue if interrupt registration fails that early.