On 02/27/2020 04:12 PM, Christophe Leroy wrote: > > > Le 27/02/2020 à 11:33, Anshuman Khandual a écrit : >> This adds new tests validating arch page table helpers for these following >> core memory features. These tests create and test specific mapping types at >> various page table levels. >> >> * SPECIAL mapping >> * PROTNONE mapping >> * DEVMAP mapping >> * SOFTDIRTY mapping >> * SWAP mapping >> * MIGRATION mapping >> * HUGETLB mapping > > For testing HUGETLB mappings, you also have to include tests of hugepd functions/helpers. Not all archictures have hugepage size which matches with page tables levels (e.g. powerpc). Those architectures use hugepd_t. Dont see much hugepd_t in generic HugeTLB. Just wondering which generic hugepd helpers can be tested here. Could you please be bit more specific. As we have not yet started looking for arch specific page table helpers test requirements, all the test scenarios here need to be generic. > > Christophe >